Skip to content

Conversation

@mikekeda
Copy link
Contributor

@mikekeda mikekeda commented Aug 19, 2020

https://github.com/dmclain/django-debug-toolbar-line-profiler is abandoned (last commit was 5years ago)
It doesn't work with django 3 and django-debug-toolbar 2
Changes - https://github.com/dmclain/django-debug-toolbar-line-profiler/pull/21/files

This fork works with Django 3.1 and django-debug-toolbar 2.2

@matthiask
Copy link
Member

Thank you! It's a bit confusing that the repository and the import path doesn't match the package name on PyPI.

Maybe you should rename the repository and imports while you're at it?

(That's not a request for change, just a question/suggestion.)

@mikekeda
Copy link
Contributor Author

I discussed this with @Mogost and decided to change only the name on pypi and not change the internal structure, this will give a smooth transition from the old version to the new one.

@matthiask matthiask merged commit e3a0758 into django-commons:master Aug 19, 2020
@Mogost
Copy link
Member

Mogost commented Aug 19, 2020

Nice work @mikekeda. I was just about to update the links, but you are faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants